Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add label for issue template #14

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

longyue0521
Copy link
Contributor

  1. 为issue模版添加label字段,使其自动标记为对应的label,方便issue过滤
  2. 缺少Proposal label需要拥有权限的同学添加一下, proposal模版中用到了该label
  3. 是否需要添加一个与questionlabel对应的issue template?

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (738e983) 77.79330% compared to head (6468ec6) 77.84916%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main         #14         +/-   ##
===================================================
+ Coverage   77.79330%   77.84916%   +0.05585%     
===================================================
  Files             45          45                 
  Lines           3580        3580                 
===================================================
+ Hits            2785        2787          +2     
+ Misses           581         579          -2     
  Partials         214         214                 
Flag Coverage Δ
unittests 77.84916% <ø> (+0.05585%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liuzengh liuzengh self-requested a review October 26, 2023 03:07
@liuzengh
Copy link
Contributor

  1. 很好的提议,接受
  2. 已经添加 proposal label
  3. 可以,欢迎贡献新的 issue template,可以参考已有 issue template 做对应调整。

Copy link
Contributor

@Leoyoungxh Leoyoungxh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@WineChord WineChord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WineChord WineChord merged commit 3b8df59 into trpc-group:main Oct 26, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
@longyue0521 longyue0521 deleted the issue_template branch October 26, 2023 04:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants